OCPBUGS-76986: Above-the-sea UI QE test second phase by ElayAharoni · Pull Request #3453 · openshift-assisted/assisted-installer-ui

ElayAharoni · 2026-03-10T10:44:08Z

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

Bug Fixes
- Improved MAC address validation error messaging for consistent string handling.
- Enhanced IP address validation with clearer error messages displaying invalid input values.
- Fixed form field indication of required IP address inputs for better user guidance.

Signed-off-by: Elay Aharoni <elayaha@gmail.com>

openshift-ci-robot · 2026-03-10T10:44:14Z

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-10T10:45:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 34bafbf5-1e3a-4fc8-ad76-4dad16e9f0d0

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd860c and 2b9c0bc.

📒 Files selected for processing (3)

libs/ui-lib/lib/common/validationSchemas/addressValidation.tsx
libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/commonValidationSchemas.tsx
libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx

📝 Walkthrough

Walkthrough

This PR updates MAC address and IP address validation schemas to improve error messaging and input handling, and adds a required field indicator to IP address form fields in static IP configuration.

Changes

Cohort / File(s)	Summary
Validation Schema Updates `libs/ui-lib/lib/common/validationSchemas/addressValidation.tsx`, `libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/commonValidationSchemas.tsx`	MAC address validation now accepts a params object and coerces values to string with empty string fallback. IP address validation adds dynamic error messages with quoted values and explicit handling for empty and non-string inputs.
Form Field Configuration `libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx`	Adds isRequired prop to FormGroup wrapping IP address fields to align with child field requirements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

NO-ISSUE: Localise validation messages #3379: Directly related at the code level as this PR modifies the same validation schemas and form fields for MAC/IP address handling.

Suggested labels

lgtm, approved, size/M

Suggested reviewers

rawagner
jgyselov

Poem

🐰 A hop through schemas, refined and clear,
MAC and IP validations now appear,
With messages bright and types that care,
Forms marked required, validation fair! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references a Jira ticket (OCPBUGS-76986) but does not clearly describe the actual technical changes made in the pull request.	Update the title to describe the main technical changes: validation schema improvements for MAC addresses and IP addresses, or use a more descriptive title that captures the actual code modifications.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-03-10T10:47:15Z

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

Bug Fixes

Improved MAC address validation error messaging for consistent string handling.

Enhanced IP address validation with clearer error messages displaying invalid input values.

Fixed form field indication of required IP address inputs for better user guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-03-10T11:17:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-03-10T11:21:05Z

@ElayAharoni: Jira Issue OCPBUGS-76986: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-76986 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

Bug Fixes

Improved MAC address validation error messaging for consistent string handling.

Enhanced IP address validation with clearer error messages displaying invalid input values.

Fixed form field indication of required IP address inputs for better user guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This reverts commit c2499bc.

* Revert "Above-the-sea UI QE test second phase (#3453)" This reverts commit c2499bc. * Revert "above sea level QE test fix (#3450)" This reverts commit 2dd860c. * Revert "Include additional operators in OVE UI ISO config (#3413)" This reverts commit dc463bb. * Revert "OCPBUGS-76280: Next button is disabled on optional configurations page (#3402)" This reverts commit a5428af. * Revert "UI freezes when clicking Select button without version (#3401)" This reverts commit 52c39a9. * Revert "OCPBUGS-75072 | OVE UI: Above-the-sea UI QE test (#3383)" This reverts commit f61e1b1. * Revert "OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message (#3376)" This reverts commit 142fdc5. * Revert "Add additional new fields to the above the sea UI (#3337)" This reverts commit 2283bcd. * Revert "Assisted Installer OVE UI shows transient blank page with Technology Preview spinner (#3341)" This reverts commit d47ab5f. * Revert "add new fields to above sea level ABI (#3274)" This reverts commit 41a3210.

This reverts commit c2499bc.

* Revert "Include additional operators in OVE UI ISO config (#3413)" This reverts commit dc463bb. * Revert "above sea level QE test fix (#3450)" This reverts commit 2dd860c. * Revert "Above-the-sea UI QE test second phase (#3453)" This reverts commit c2499bc. * Revert "OCPBUGS-76280: Next button is disabled on optional configurations page (#3402)" This reverts commit a5428af. * Revert "UI freezes when clicking Select button without version (#3401)" This reverts commit 52c39a9. * Revert "OCPBUGS-75072 | OVE UI: Above-the-sea UI QE test (#3383)" This reverts commit f61e1b1. * Revert "OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message (#3376)" This reverts commit 142fdc5. * Revert "Add additional new fields to the above the sea UI (#3337)" This reverts commit 2283bcd. * Revert "Assisted Installer OVE UI shows transient blank page with Technology Preview spinner (#3341)" This reverts commit d47ab5f. * Revert "add new fields to above sea level ABI (#3274)" This reverts commit 41a3210. * Fix OCM wizard types after above-sea revert chain Import isThirdPartyCNI from common network types (not ocm utils). Review step: drop stale disconnectedInfraEnv reference; arch matches static ISO URL. * fix revert bugs Signed-off-by: Elay Aharoni <elayaha@gmail.com> --------- Signed-off-by: Elay Aharoni <elayaha@gmail.com>

Above-the-sea UI QE test second phase

2b9c0bc

Signed-off-by: Elay Aharoni <elayaha@gmail.com>

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2026

openshift-ci bot requested review from LiorSoffer and jkilzi March 10, 2026 10:44

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 10, 2026

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 10, 2026

rawagner approved these changes Mar 10, 2026

View reviewed changes

openshift-ci bot assigned rawagner Mar 10, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2026

openshift-merge-bot bot merged commit c2499bc into openshift-assisted:master Mar 10, 2026
14 checks passed

coderabbitai bot mentioned this pull request Mar 12, 2026

MGMT-23288: UI doesnt save the data filled by the user #3452

Merged

ElayAharoni added a commit to ElayAharoni/assisted-installer-ui that referenced this pull request Mar 23, 2026

Revert "Above-the-sea UI QE test second phase (openshift-assisted#3453)"

4c7f34d

This reverts commit c2499bc.

ElayAharoni added a commit to ElayAharoni/assisted-installer-ui that referenced this pull request Mar 30, 2026

Revert "Above-the-sea UI QE test second phase (openshift-assisted#3453)"

e5fbf7c

This reverts commit c2499bc.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-76986: Above-the-sea UI QE test second phase#3453

OCPBUGS-76986: Above-the-sea UI QE test second phase#3453
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
ElayAharoni:above-the-sea-UI-QE-test-second-phase

ElayAharoni commented Mar 10, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Summary by CodeRabbit

Uh oh!

openshift-ci bot commented Mar 10, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ElayAharoni commented Mar 10, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Summary by CodeRabbit

Uh oh!

openshift-ci bot commented Mar 10, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Summary by CodeRabbit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ElayAharoni commented Mar 10, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 10, 2026 •

edited

Loading